Skip to content

Migrate projects_dropdown.vue to GlCollapsibleListbox

Ross Byrne requested to merge 386027-migrate-projects_dropdown into master

What does this MR do and why?

Migrates GlDropdown in app/assets/javascripts/projects/commit/components/projects_dropdown.vue to GlCollapsibleListbox (see #386027 (closed)).

This change was original part of !106863 (merged) which was subsequently reverted in !109569 (merged) due to master:broken, see gitlab-org/quality/engineering-productivity/master-broken-incidents#668 (closed).

Screenshots or screen recordings

Before After
Screenshot_2022-12-16_at_16.16.36 Screenshot_2022-12-16_at_16.11.06
Screenshot_2022-12-16_at_16.16.26 Screenshot_2023-01-11_at_13.44.56

How to set up and validate locally

  1. Navigate to project > commits
  2. Select a commit
  3. Select dropdown called "Options" in top right
  4. Select option "Cherry-pick"
  5. Migrated dropdown is the projects dropdown under the heading "Pick into project"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #386027 (closed)

Edited by Ross Byrne

Merge request reports