Add default value for inbound_job_token_scope_enabled
What does this MR do and why?
This MR sets a default value for inbound_job_token_scope_enabled based on whether the feature flag is enabled or not. This is first set to carry out work described in this issue. Next step is to create a migration that will set the default value at the database level, which will come shortly after this MR.
For reviewer: You will see a long thread where we are discussing what approach should be taken. We have settled on using default_value_for.
This gem is actually being removed atm as its not being maintained, but given that we plan to remove this usage as well when we will be deleting the flag (very soon, either this or next milestone), we have decided to use it for the time being.
Screenshots or screen recordings
This MR sets a default value to
How to set up and validate locally
- Enable the flag locally and create a new project
- Verify that the value saved in project_ci_cd_settings for inbound_job_token_scope_enabled is true
gdk psql
\c gitlabhq_development
select * from project_ci_cd_settings-> see last column value for the project that you just created.
The process can be repeated with the flag disabled locally. When the flag is disabled, we expect the value to be set to false as per the database level defaults.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.