Skip to content

WIP: Add leave link to member_access_granted email

Luke Bennett requested to merge member-access-granted-leave-email into master

What does this MR do?

  • Add leave link to member_access_granted email

  • Add url helper methods for leave actions (leave_project_members_url/leave_group_members_url)

  • Allow GET requests to leave actions

  • Add email_token to auth protected endpoints for one-click email actions

Screenshot_2019-04-13_at_16.46.04

Screenshot_2019-04-13_at_17.08.34

Clicking/visiting the leave link will perform the leave action and direct the user to their dashboard with a flash notice.

Screenshot_2019-04-13_at_17.35.45

Screenshot_2019-04-27_at_16.45.46

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59421

How can I preview the email?

Visit: http://localhost:3001/rails/mailers/notify/member_access_granted_email.html

https://docs.gitlab.com/ee/development/emails.html#mailer-previews

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Luke Bennett

Merge request reports