Draft: POC: work items at group level
What does this MR do and why?
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @acroitor
- A deleted user
added backend database databasereview pending frontend labels
4 Warnings This merge request is definitely too big (2493 lines changed), please split it into multiple merge requests. This merge request does not refer to an existing milestone. Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. 3 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/issuable_finder/params.rb
app/finders/issuable_finder.rb
app/finders/issues_finder.rb
Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eulyeon K. (
@euko
) (UTC+0, 3 hours behind@acroitor
)Mayra Cabrera (
@mayra-cabrera
) (UTC-6, 9 hours behind@acroitor
)database Sincheol (David) Kim (
@dskim_gitlab
) (UTC+10.5, 7.5 hours ahead of@acroitor
)Eulyeon K. (
@euko
) (UTC+0, 3 hours behind@acroitor
)frontend Artur Fedorov (
@arfedoro
) (UTC+2, 1 hour behind@acroitor
)Phil Hughes (
@iamphill
) (UTC+1, 2 hours behind@acroitor
)product intelligence Sebastian Rehm (
@bastirehm
) (UTC+2, 1 hour behind@acroitor
)Maintainer review is optional for product intelligence maintenanceworkflow / maintenancepipelines for CI, Danger Thomas Hutterer (
@thutterer
) (UTC+2, 1 hour behind@acroitor
)Rémy Coutable (
@rymai
) (UTC+2, 1 hour behind@acroitor
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @acroitor - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3decae8b and 224f0e49
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.62 MB 3.62 MB - -0.0 % mainChunk 2.08 MB 2.08 MB - 0.0 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.work_items 0 Bytes 946.03 KB +946.03 KB 100.0 %
Note: We do not have exact data for 3decae8b. So we have used data from: fe3d3ab5.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for ab8e26a8expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ | Plan | 46 | 3 | 1 | 0 | 50 | ❌ | +-------+--------+--------+---------+-------+-------+--------+ | Total | 46 | 3 | 1 | 0 | 50 | ❌ | +-------+--------+--------+---------+-------+-------+--------+
Setting label groupproject management based on
@acroitor
's group.added groupproject management label
added devopsplan sectiondev labels
added 2476 commits
-
ab8e26a8...cdb2eaaf - 2475 commits from branch
master
- 236cee44 - POC: work items at group level
-
ab8e26a8...cdb2eaaf - 2475 commits from branch
- A deleted user
added product intelligence product intelligencereview pending labels
added 5403 commits
-
14b22959...59f32e48 - 5400 commits from branch
master
- 38dfc7eb - POC: work items at group level
- d1e3f3b5 - Create work item at group level
- ca95c529 - Scope issues iid to namespace
Toggle commit list-
14b22959...59f32e48 - 5400 commits from branch
- A deleted user
added documentation label
added 104 commits
-
dd9e3e46...820f00c5 - 98 commits from branch
master
- 4626367b - Scope issue model iid to namespace
- 729c5178 - Create work items at group level
- e5d42f64 - POC: work items at group level
- 16a48604 - Create work item at group level
- 4421bf33 - Scope issues iid to namespace
- 3b4114d7 - Display work item at group level.
Toggle commit list-
dd9e3e46...820f00c5 - 98 commits from branch
added 1024 commits
-
3b4114d7...758e6d6f - 1023 commits from branch
master
- 2b1f71b7 - Handle work items at group level
-
3b4114d7...758e6d6f - 1023 commits from branch
added 1212 commits
-
2b1f71b7...5caa3479 - 1209 commits from branch
master
- d4840f80 - Create work items at group level
- 918f0e31 - Handle work items at group level
- e6edd381 - Fix graphql doc generation for interfaces
Toggle commit list-
2b1f71b7...5caa3479 - 1209 commits from branch
added 1325 commits
-
e6edd381...221f96aa - 1322 commits from branch
master
- 011c5281 - Create work items at group level
- 0f29da3a - Handle work items at group level
- 224f0e49 - Fix graphql doc generation for interfaces
Toggle commit list-
e6edd381...221f96aa - 1322 commits from branch
Setting label(s) Category:Team Planning based on groupproject management.
added Category:Team Planning label
added typemaintenance label