Skip to content

Removes Bizible if invite_email present on signup

Ross Byrne requested to merge 377339-remove-bizible-when-invite-email-present into master

What does this MR do and why?

This MR removes Bizible from /users/sign_up when the invite_email param is present in the URL.

The aim is to eliminate leaking the user's email address, because Bizible collects the URL. See issue https://gitlab.com/gitlab-org/gitlab/-/issues/377339.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Make sure that Bizible is enabled locally by doing the following:

    • In rails console, make sure the feature flag is enabled

      Feature.enable(:ecomm_instrumentation)

    • Add the bizible config value to your gitlab.yml file

      development:
  <<: *base
  extra:
    bizible: true

  2. Navigate to http://127.0.0.1:3000/users/sign_up?invite_email=test@test.com

  3. Check that Bizible is not installed and running. Check by Running Bizible in the Javascript console to get an object or checking the network requests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #377339

Edited by Ross Byrne

Merge request reports