Update milestone param in issuable update service

Heinrich Lee Yurequested to merge
issuable-update-service-remove-milestone-param into master

What does this MR do and why?

Today, the issuable update services accepts both milestone and milestone_id params. milestone_id is the main one that is used because this comes from the request params. We can't use milestone there because we can't pass in a Milestone object from an HTTP request param.

This MR removes support for the milestone param which is mainly used by our specs. MergeRequests::PushOptionsHandlerService and the MergeRequestSetMilestone mutation also use this but both have also been updated in this MR to pass in the milestone_id instead.

This is extracted from !109189 (merged) where I'm trying to consolidate the milestone processing logic. Having only one param simplifies things.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports