Skip to content

Fixed some layout and functional issues with language project filter

Marco Zille requested to merge gitlab-community/gitlab:386237-zillemarco-fix-project-language-filter-issues into master

What does this MR do and why?

Related to #386237 (closed).

This MR fixes the layout and functional issues mentioned in the above issue 🙂

Screenshots or screen recordings

These are the screen recordings about the layout issues (how they're behaving now that they're solved):

Registrazione_schermo_2023-01-18_alle_21.25.10

Registrazione_schermo_2023-01-18_alle_21.24.11

This one is to show the fixed language filter getting lost when changing other params:

Registrazione_schermo_2023-01-19_alle_13.09.47

How to set up and validate locally

Enabled project_language_search from the rails console (Feature.enable(:project_language_search)) and make sure the layout works at different sizes and the filtering works, on both projects dashboard (http://127.0.0.1:3000/dashboard/projects) and admin projects pages (http://127.0.0.1:3000/admin/projects) 🙂

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports