Skip to content

Refactor the group_service_spec

Ravi Kumar requested to merge 372253_group_service_spec_improvement into master

What does this MR do and why?

  • Remove :clean_gitlab_redis_shared_state because elasticsearch traits dynamically use the :clean_gitlab_redis_shared_state trait
  • Move the shared example search respects visibility to the shared_examples/ folder
  • Move out the visibility#blob_and_commit into a different file. It was alone taking more than half of the total time.

Screenshots or screen recordings

After the code change after_extraction

Original Screenshot_2023-01-19_at_14.27.47

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #372253 (closed)

Edited by Ravi Kumar

Merge request reports