Danger warning for deprecated .qa-selector

What does this MR do and why?

Describe in detail what your merge request does and why.

Detects deprecated .qa-selector class being re-introduced and issues a Danger warning with a link to documentation.

Last task of gitlab-org/quality/quality-engineering/team-tasks#1294 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added QA Quality maintenanceworkflow typemaintenance labels

assigned to @a_mcdonald

	1 Warning
	If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs). If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding ~"regression:*" label, and re-run the danger job (there is a link at the bottom of this comment).

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
maintenanceworkflow / maintenancepipelines for CI, Danger	Krasimir Angelov (@krasio) (UTC+13, same timezone as @a_mcdonald)	David Dieulivol (@ddieulivol) (UTC+1, 12 hours behind @a_mcdonald)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed milestone to %15.9

added 1 commit

• c1fea72b - Test adding deprecated selector

Compare with previous version

added frontend label

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 6790a884 and c1fea72b

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.52 MB	3.52 MB	-	-0.0 %
mainChunk	1.95 MB	1.95 MB	-	0.0 %

---

Note: We do not have exact data for 6790a884. So we have used data from: d00fdb6f.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

mentioned in merge request !109266 (closed)

added 509 commits

• c1fea72b...dfc4c7a2 - 508 commits from branch master
• c49ed029 - Danger warning for deprecated .qa-selector

Compare with previous version

changed the description

Tested in !109266 (closed):

added 1 commit

• c78aa526 - Danger warning for deprecated .qa-selector

Compare with previous version

marked this merge request as ready

mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#1294 (closed)

@dchevalier2 Could you do a review from Quality side please? Would love to get your opinion since you have done so much work on deprecated qa selectors already.

requested review from @dchevalier2

approved this merge request

removed review request for @dchevalier2

@dchevalier2, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

resolved all threads

@ddieulivol Could you do a review from CI/Danger side please?

requested review from @ddieulivol

approved this merge request

removed review request for @ddieulivol

resolved all threads

enabled an automatic merge when the pipeline for ec101289 succeeds

merged

mentioned in commit c9acd9a8

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label