Skip to content

Enable feature only when required ArkoseLabs credentials are present

Eugie Limpin requested to merge el-ensure-arkose-labs-credentials-present into master

Resolves https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/207

What does this MR do?

Skip ArkoseLabs integration code paths during signup unless all setting values needed for the feature are present.

Why?

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/370932+ is ensuring that existing e2e tests are passing before enabling the feature flag in staging and production. Since we will be rolling out the feature for GitLab.com only (no plans for self-managed release yet), this MR prevents the feature from running (with its feature flag enabled) while executing e2e tests for self-managed instances (e2e:package-and-test job). This works because ArkoseLabs credentials are not set for the Omnibus instance used to run e2e:package-and-test.

Quality team is working on having registration e2e tests run against staging in gitlab-org/quality/quality-engineering/team-tasks#1605.

Screenshots or screen recordings

N/A

How to validate

e2e:package-and-test should pass when arkose_labs_signup_challenge FF is set to default_enabled: true

Passing e2e:package-and-test job: https://gitlab.com/gitlab-org/gitlab/-/pipelines/751480252

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eugie Limpin

Merge request reports