Resolve "Deployments::HooksWorker args do not serialize to JSON safely"

changed milestone to %15.9

added Category:Environment Management backend devopsrelease [DEPRECATED] grouprelease [DEPRECATED] priority4 sectionops severity4 typebug workflowready for development + 1 deleted label

assigned to @halilcoban

added 1 commit

2187e23a - Serialize hooks worker params for sidekiq

Compare with previous version

added feature flag label

	5 Warnings
	If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs). If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding `~"regression:*"` label, and re-run the danger job (there is a link at the bottom of this comment).
	cc17f22f: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	cc17f22f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	3ed9f804: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	Please add a merge request subtype to this merge request.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Max Fan (`@mfangitlab`) (UTC-8)	Jessie Young (`@jessieay`) (UTC-8)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c2bd7e8d

Allure report

allure-report-publisher generated test report!

e2e-package-and-test: test report for cc17f22f

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 292    | 0      | 40      | 20    | 332   | ❗     |
| Manage           | 132    | 0      | 6       | 4     | 138   | ❗     |
| Verify           | 98     | 0      | 4       | 0     | 102   | ✅     |
| Plan             | 120    | 0      | 0       | 0     | 120   | ✅     |
| Govern           | 84     | 0      | 2       | 0     | 86    | ✅     |
| Release          | 12     | 0      | 0       | 0     | 12    | ✅     |
| Fulfillment      | 4      | 0      | 50      | 0     | 54    | ✅     |
| Analytics        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
| Package          | 0      | 0      | 6       | 0     | 6     | ➖     |
| Configure        | 0      | 0      | 6       | 0     | 6     | ➖     |
| Secure           | 14     | 0      | 2       | 0     | 16    | ✅     |
| Monitor          | 10     | 0      | 0       | 0     | 10    | ✅     |
| ModelOps         | 0      | 0      | 2       | 0     | 2     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 770    | 0      | 120     | 24    | 890   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

17b466d1 - Serialize hooks worker params for sidekiq

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e77f97e2

added 1 commit

72bbca85 - Serialize hooks worker params for sidekiq

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@37b22953

marked this merge request as ready

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

requested review from @shinya.maeda

added workflowin review label and removed workflowready for development label

Hi @shinya.maeda

Can you review this MR?

I've tested locally and it works as expected. Also, I decided to put it behind a feature flag and rollout gradually, because in case something unexpected happens we can monitor the Sidekiq queue and take action to disable new serialization code.