Skip to content

Revert "fail-rspec-job-when-errors-occur-outside-of-examples"

Nao Hashizume requested to merge revert-c2c1dae9 into master

What does this MR do and why?

This reverts !107878 (merged) which caused broken master: #388020 (closed) and gitlab-org/quality/engineering-productivity/master-broken-incidents#569 (closed).

This will prevent retry_failed_rspec_examples from being called repeatedly until the job exited due to a timeout.

Related to #388020 (closed)

Example job

When spec/db/docs spec.rb fails, the rspec unit pg12 job exits instead of getting stuck: https://gitlab.com/gitlab-org/gitlab/-/jobs/3597402550.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nao Hashizume

Merge request reports