Resize component on alert dismiss (!108811) · Merge requests · GitLab.org / GitLab

Eduardo Sanz García requested to merge eduardosanz/terms-and-conditions into master Jan 12, 2023

What does this MR do and why?

The functionality to resize the Terms and Conditions Vue component is broken. We replace the functionality for an observer. This is a simpler and more flexible solution.

Screenshots or screen recordings

Before

Screen_Recording_2022-12-14_at_16.19.34

After

Screen_Recording_2022-12-14_at_15.54.59

How to set up and validate locally

For the terms and condition Vue component resizing:

In the Admin area > Settings > General > Terms and conditions, add your terms: https://gdk.test:3443/admin/application_settings/general#js-terms-settings
Select All users must accept the Terms of Service and Privacy Policy to access GitLab checkbox
Select Save changes
Go to: https://gdk.test:3443/-/users/terms
Remove the alert
Observe the term and conditions section expanding to occupy the whole window.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

I have evaluated the MR acceptance checklist for this MR.

Edited Jan 12, 2023 by Eduardo Sanz García

Resize component on alert dismiss