Skip to content

Resolve: "External status check Retry button breaks when building URL"

Elwyn Benson requested to merge 387886-external-status-check-retry-button-breaks-when-building-url into master

What does this MR do and why?

Fix bug on MRs with a failed external status check, clicking the Retry button does nothing. This is because the code failed to correctly build the URL for the API endpoint it needs to hit.

Screenshots or screen recordings

Button previously did nothing when clicked. Now shows spinner when clicked.

How to set up and validate locally

  1. Add an external status check to a project
  2. Open a MR with a change that will cause the external check to fail
  3. Wait for the external status check to fail, refresh MR
  4. Expand the status check widget
  5. Click "Retry"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #387886 (closed)

Edited by Elwyn Benson

Merge request reports