Add Incident Tag help popover to timeline add/edit forms
What does this MR do and why?
- adds an icon that shows a popover when triggered, with information about incident event tags & with a link to documentation (it's being added here: !107209 (merged) )
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Open the Rails Console in a terminal under the gitlab/ folder: rails c
- Run Feature.enable(:incident_event_tags) to enable to feature globally for your GitLab instance.
- Navigate to Monitor > Incidents page
- Create new or open an existing incident
- Navigate to Timeline tab of the incident
- Click "Edit" button in the More dropdown of a specific event or "Add new timeline event"
- Click a question mark next to "the tags dropdown"Event tag (optional)" headline to trigger the popover.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #373854 (closed)
Merge request reports
Activity
changed milestone to %15.8
assigned to @psjakubowska
removed documentation label
- A deleted user
added backend feature flag frontend labels
4 Warnings If you are in a revert MR, consider using the revert MR template to add labels to skip changelog checks (docs). If this is reverting something in the current milestone, we don't need to add a changelog. In this case, we can skip changelog checks by adding
~"regression:*"
label, and re-run the danger job (there is a link at the bottom of this comment).ee608965: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. b3d31e15: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Laura Meckley (
@lmeckley
) (UTC-7)Jose Ivan Vargas (
@jivanvl
) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3746355c and ee608965
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.55 MB 3.55 MB - -0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 % Significant Reduction: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.geo.settings 184.27 KB 180.16 KB -4.11 KB -2.2 % pages.groups.ldap_group_links 40.04 KB 35.94 KB -4.11 KB -10.3 %
Note: We do not have exact data for 3746355c. So we have used data from: ed1ad051.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for ee608965expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 28 | 0 | 5 | 0 | 33 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 12 | 0 | 175 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 704e5603expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 320 | 2 | 10 | 2 | 332 | ❌ | | Verify | 96 | 0 | 6 | 2 | 102 | ❗ | | Manage | 126 | 2 | 6 | 2 | 134 | ❌ | | Plan | 120 | 0 | 0 | 0 | 120 | ✅ | | Fulfillment | 4 | 0 | 28 | 0 | 32 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 84 | 0 | 2 | 0 | 86 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Secure | 14 | 0 | 2 | 0 | 16 | ✅ | | Release | 12 | 0 | 0 | 0 | 12 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 788 | 4 | 70 | 6 | 862 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added featureaddition label
added 1312 commits
-
704e5603...31971a13 - 1308 commits from branch
master
- 2651af8e - Allow to add incident tag when creating event
- caa609d0 - Apply code review suggestions
- 42754060 - Improve auto-message mechanism and tests
- 9b589d93 - Add popover to event tags dropdown
Toggle commit list-
704e5603...31971a13 - 1308 commits from branch
- Resolved by Jacques Erasmus
added 246 commits
-
9141bbda...2b719fe4 - 242 commits from branch
master
- c5636b06 - Allow to add incident tag when creating event
- a43efe63 - Apply code review suggestions
- bccf6b54 - Improve auto-message mechanism and tests
- 76b7b971 - Add popover to event tags dropdown
Toggle commit list-
9141bbda...2b719fe4 - 242 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @djadmin
- Resolved by Jacques Erasmus
Hi @djadmin! Would you mind reviewing this change for the incident timeline? Thank you!
added workflowin review label and removed workflowin dev label
added 1 commit
- 0f94cbd4 - Event tags popover should show on hover event
added 1 commit
- c427e334 - Event tags popover should show on hover event
removed backend label
changed milestone to %15.9
- Resolved by Dheeraj Joshi
- Resolved by Dheeraj Joshi
- Resolved by Dheeraj Joshi
- Resolved by Dheeraj Joshi
- Resolved by Dheeraj Joshi
- Resolved by Dheeraj Joshi
removed review request for @djadmin
added 958 commits
-
c427e334...5beffd5d - 955 commits from branch
master
- b3d31e15 - Add popover to event tags dropdown
- 8981c554 - Event tags popover should show on hover event
- ee608965 - Appply code review suggestions
Toggle commit list-
c427e334...5beffd5d - 955 commits from branch
requested review from @djadmin
- Resolved by Jacques Erasmus
@djadmin
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 44c16bea succeeds
mentioned in commit e2b20e60
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#193 (closed)
mentioned in issue gitlab-org/monitor/respond#194 (closed)
mentioned in issue gitlab-org/monitor/respond#195 (closed)
mentioned in issue gitlab-com/www-gitlab-com#13612 (closed)
mentioned in issue gitlab-org/monitor/respond#200 (closed)
added releasedpublished label and removed releasedcandidate label