Skip to content

Fix async callback not called on test

Eduardo Sanz García requested to merge eduardosanz/investigate-callback-test-issue into master

What does this MR do and why?

It seems that in certain situations a callback is not called (https://gitlab.com/gitlab-org/gitlab/-/jobs/3581867302#L537) in these tests.

We replace mount with shallowMount in the spec. With mount, we're rendering the full components-tree which includes related-issuable-item and all of its children. This makes the tests' complexity hard to control as any change to a component within the tree might affect related-merge-requests' spec, and potentially exceeds Jest's timeout setting.

Fixes #387789 (closed)

Fixes #387756 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports