Skip to content

Improve lookbook button component preview with icon

Thomas Hutterer requested to merge fix_lookbook_button_icons into master

What does this MR do and why?

This is very small fix for one of our Lookbook ViewComponent previews. Before this change, when previewing the button component, you had to type in a valid icon name by hand if you wanted to see the button with a different icon. But a wrong icon name or even an empty field made the preview raise an error. Now it uses a selectbox with a couple if icons and the option to preview buttons without any icon.

This is the exact same approach we took already for our badges component preview.

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports