Skip to content
Snippets Groups Projects

Resolve "GitLab Migration - History page inconsistencies"

Merged Illya Klymov requested to merge 383759-gitlab-migration-history-page-inconsistencies into master
All threads resolved!

What does this MR do and why?

This MR improves history page according to #383759 (closed)

  • changed column names
  • fixes wrong handling of projects with space names
  • added icons

Screenshots or screen recordings

Before After
127.0.0.1_3000_import_bulk_imports_history__7_ 127.0.0.1_3000_import_bulk_imports_history__6_

How to set up and validate locally

  • Enable feature flag :bulk_import_projects in rails console: Feature.enable(:bulk_import_projects)
  • In GitLab admin settings turn on Enable migrating GitLab groups and projects by direct transfer and save changes /admin/application_settings/general#js-visibility-settings
  • Open "New group" -> Import (/groups/new)
  • Use https://gitlab.com as source instance and GeK1Nis4j-SY1X4sqE5c as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here)
  • Import top-level-group-1 (it contains project)
  • Open History page /bulk_imports/history
  • Observe the result

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan MH

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan MH
  • Dan MH
  • mentioned in issue danmh/danmh#12 (closed)

  • Illya Klymov added 1 commit

    added 1 commit

    Compare with previous version

  • Illya Klymov added 1 commit

    added 1 commit

    • 2333a7a6 - Add tooltip for icons in history

    Compare with previous version

  • Illya Klymov added 1 commit

    added 1 commit

    • e3d69652 - Add tooltip for icons in history

    Compare with previous version

  • Dan MH approved this merge request

    approved this merge request

  • Dan MH removed review request for @danmh

    removed review request for @danmh

  • Dan MH changed the description

    changed the description

  • added UI polish label

  • mentioned in issue danmh/danmh#13 (closed)

  • Illya Klymov added 1 commit

    added 1 commit

    • 0b5be087 - Add tooltip for icons in history

    Compare with previous version

  • Doug Stull requested review from @justin_ho and removed review request for @dstull

    requested review from @justin_ho and removed review request for @dstull

  • Doug Stull approved this merge request

    approved this merge request

  • Mayra Cabrera
  • Mayra Cabrera approved this merge request

    approved this merge request

  • Mayra Cabrera removed review request for @mayra-cabrera

    removed review request for @mayra-cabrera

  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong
  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong removed review request for @justin_ho

    removed review request for @justin_ho

  • Illya Klymov added 1 commit

    added 1 commit

    • e2e38750 - Improve spec by removing duplication

    Compare with previous version

  • Illya Klymov requested review from @rob.hunt

    requested review from @rob.hunt

  • Justin Ho Tuan Duong approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong requested review from @justin_ho and removed review request for @rob.hunt

    requested review from @justin_ho and removed review request for @rob.hunt

  • Justin Ho Tuan Duong resolved all threads

    resolved all threads

  • Justin Ho Tuan Duong enabled an automatic merge when the pipeline for 4d78553e succeeds

    enabled an automatic merge when the pipeline for 4d78553e succeeds

  • mentioned in commit 812be818

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #388193 (closed)

  • 🤖 GitLab Bot 🤖 added groupimport and integrate label and removed 1 deleted label

    added groupimport and integrate label and removed 1 deleted label

  • Please register or sign in to reply
    Loading