Resolve "GitLab Migration - History page inconsistencies"
What does this MR do and why?
This MR improves history page according to #383759 (closed)
- changed column names
- fixes wrong handling of projects with space names
- added icons
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable feature flag
:bulk_import_projects
in rails console:Feature.enable(:bulk_import_projects)
- In GitLab admin settings turn on
Enable migrating GitLab groups and projects by direct transfer
and save changes/admin/application_settings/general#js-visibility-settings
- Open "New group" -> Import (
/groups/new
) - Use
https://gitlab.com
as source instance andGeK1Nis4j-SY1X4sqE5c
as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here) - Import
top-level-group-1
(it contains project) - Open History page
/bulk_imports/history
- Observe the result
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.8
added Category:Importers Importer:Direct Transfer UX bugux devopsmanage documentation frontend milestonep1 priority2 sectiondev severity3 typebug workflowin dev + 1 deleted label
assigned to @xanf
added 233 commits
-
5469efcc...fff364b3 - 232 commits from branch
master
- 3ce17dbc - Improve GitLab Migration history page
-
5469efcc...fff364b3 - 232 commits from branch
- A deleted user
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Lee Tickett (
@leetickett-gitlab
) (UTC+0, 2 hours behind@xanf
)Felipe Artur (
@felipe_artur
) (UTC-3, 5 hours behind@xanf
)frontend Dheeraj Joshi (
@djadmin
) (UTC+5.5, 3.5 hours ahead of@xanf
)Natalia Tepluhina (
@ntepluhina
) (UTC+1, 1 hour behind@xanf
)test for spec/features/*
Sean Gregory (
@sgregory2
) (UTC-5, 7 hours behind@xanf
)Maintainer review is optional for test for spec/features/*
UX Emily Sybrant (
@esybrant
) (UTC-6, 8 hours behind@xanf
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed backend label
requested review from @danmh
- Resolved by Justin Ho Tuan Duong
@bauerdominic could you please review backend changes?
I'm exposing required fields for me in API
- Resolved by Justin Ho Tuan Duong
requested review from @dstull
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a1c71270 and e2e38750
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - -0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.import.bulk_imports.history 277.7 KB 225.03 KB -52.67 KB -19.0 %
Note: We do not have exact data for a1c71270. So we have used data from: ddbbfbc1.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- A deleted user
added backend label
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for e2e38750expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 24 | 0 | 5 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 155 | 0 | 12 | 0 | 167 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @mayra-cabrera
@bauerdominic
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Illya Klymov
- Resolved by Illya Klymov
- Resolved by Illya Klymov
mentioned in issue danmh/danmh#12 (closed)
removed review request for @danmh
added UI polish label
mentioned in issue danmh/danmh#13 (closed)
requested review from @justin_ho and removed review request for @dstull
- Resolved by Justin Ho Tuan Duong
removed review request for @mayra-cabrera
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Illya Klymov
removed review request for @justin_ho
- Resolved by Justin Ho Tuan Duong
@rob.hunt could you maintainerize this one, please?
requested review from @rob.hunt
requested review from @justin_ho and removed review request for @rob.hunt
enabled an automatic merge when the pipeline for 4d78553e succeeds
mentioned in commit 812be818
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #388193 (closed)
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupimport and integrate label and removed 1 deleted label