Skip to content

PoC: Create Deployment only for processable jobs

Shinya Maeda requested to merge create-deployment-in-process-build-service into master

What does this MR do and why?

Currently, we're creating deployment records in InitialPipelineProcessWorker. This change was made for Move CreateDeployments out of the pipeline crea... (#383600 - closed), however, it's a short term fix until a proper solution comes in.

This MR creates deployments for processable jobs only. "Processable" is the state that a job is able to transition to an enqueuable state, such as manual and pending. ProcessBuildService is a corresponding service to process a job.

This MR also fixes a minor UX issue that unprocessed deployment record appears in Environment Index/Details page, which are simply useless entries.

Related !108042 (merged) #383600 (closed) !103730 (closed)

Describe in detail what your merge request does and why.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports