Skip to content

Update multiple selection for existing policies

Alexander Turinske requested to merge 377865-update-multiple-selection-for-existing-policies into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Update multiple selection for existing policies

  • fill out approvers for existing policies
  • track approver type with approver id
  • update existing approvers data shape
  • make it easier to add/remove approvers
  • modify shape sooner

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

There is only one visual change and that is that the dropdown is now disabled when no available type is selectable.

Screen_Recording_2023-01-19_at_11.08.21

There are several CSS issues with the layout and those will be fixed with Update approver CSS (!109177 - merged).

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Enable the scan_result_role_action feature flag: echo "Feature.enable(:scan_result_role_action)" | rails c
  3. Navigate to http://gdk.test:3443/groups/flightjs/-/security/policies/new?type=scan_result_policy
  4. Verify that multiple actions can be added
  5. Create a policy, merge the resulting MR, navigate back to http://gdk.test:3443/groups/flightjs/-/security/policies, select the new policy and select Edit policy
  6. Verify the policy editor renders the actions correctly and it can be updated

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #377865 (closed)

Edited by Alexander Turinske

Merge request reports