Refactor welcome controller to reduce duplicating and increase clarity

What does this MR do and why?

General refactoring and resolution of rubocop issues.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #387662 (closed)