Refactor static instructions to template
What does this MR do and why?
This change refactors the Runner Registration helper for AWS, so the contents can be rendered in a separate modal.
Why now?
The AWS instructions modal will be migrated to the Runners area, so it always appears as an option. The modal body will be used to render the instructions in two places: The project CI/CD settings and the Admin Runners area. For now, only the project CI/CD settings is migrated.
| MR | |
|---|---|
| Refactor runner instructions modal components (!108309 - merged) | |
| Refactor static instructions to template (!108570 - merged) | you are here |
| Remove AWS runner deployment modal (!108591 - merged) |
Screenshots or screen recordings
How to set up and validate locally
- As a project administrator (or
root) - Visit a project's CI/CD settings -> Runners with the parameter
?ci_runner_templates=true- On my local this is the URL: http://gdk.test:3000/top-group/top-project/-/settings/ci_cd?ci_runner_templates=true#js-runners-settings
- Click on "Deploy GitLab Runner in AWS" button
- Check the modal
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #386566 (closed)
Edited by Miguel Rincon