Skip to content

Do not check for signup info on pwa controller

Doug Stull requested to merge 375628-disable-storing-with-pwa into master

What does this MR do and why?

  • prevents requests to the pwa controller from storing the return to path for a user that this method performs.
  • fixes a bug where safari actually navigates through this controller perhaps due to our manifest links not being supported in safari yet - https://caniuse.com/web-app-manifest
    • this caused the return to value set correction in trial registrations controller to be overwritten with /-/manifest.json and thus not properly remembering we were in the trial flow
    • note: Only happens on Safari(google is fine and doesn't navigate to pwa controller path)

Screenshots or screen recordings

  • before, trial is dropped due to the above from params and trial toggle shown
  • after, trial is present in params as expected and hides the toggle with correct value in UI
before after
Screen_Shot_2023-01-09_at_2.54.36_PM Screen_Shot_2023-01-09_at_2.13.06_PM

How to set up and validate locally

  1. Setup to simulate SaaS and restart GDK
    • Make sure Admin > Settings > General > Sign Up Restrictions match the below (no admin approval, but hard email confirmation) image
  2. Launch Safari and visit /-/trial_registrations/new on your gdk site.
  3. Register
  4. Confirm email by finding the confirmation path from last User created in rails console
    • Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
  5. Visit that Url
  6. Sign back in when directed.
  7. Fill in the welcome form with My company or team and submit.
  8. At this point you should see the differences shown in the before/after screenshots

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #375628 (closed)

Edited by Doug Stull

Merge request reports