Do not check for signup info on pwa controller
What does this MR do and why?
- prevents requests to the pwa controller from storing the return to path for a user that this method performs.
- fixes a bug where safari actually navigates through this controller perhaps due to our
manifest
links not being supported in safari yet - https://caniuse.com/web-app-manifest- this caused the return to value set correction in trial registrations controller to be overwritten with
/-/manifest.json
and thus not properly remembering we were in the trial flow - note: Only happens on Safari(google is fine and doesn't navigate to pwa controller path)
- this caused the return to value set correction in trial registrations controller to be overwritten with
Screenshots or screen recordings
- before, trial is dropped due to the above from params and trial toggle shown
- after, trial is present in params as expected and hides the toggle with correct value in UI
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Setup to simulate SaaS and restart GDK
- Launch Safari and visit
/-/trial_registrations/new
on your gdk site. - Register
- Confirm email by finding the confirmation path from last User created in
rails console
Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
- Visit that Url
- Sign back in when directed.
- Fill in the welcome form with
My company or team
and submit. - At this point you should see the differences shown in the before/after screenshots
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #375628 (closed)
Edited by Doug Stull