Fix variable width on manual variable inputs
What does this MR do and why?
In the "run manual job" form, there are inputs to fill in variables value. When you start typing the values, a clear icon will appear next to the input. This will have the unfortunate effect of changing the width of the input field and will
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2023-01-09_at_2.40.43_PM | Screen_Recording_2023-01-09_at_3.08.58_PM |
How to set up and validate locally
- Setup a runner for your project (see: https://docs.gitlab.com/runner/register/#macos)
- Setup a CI configuration file (
.gitlab-ci.yml
) by going to CI/CD => Editor - Note that you can have the simplest possible configuration for one single manual job like so:
job1:
script: echo hello
when: manual
- Run a pipeline
- Go to the pipeline graph
- Click on the job action "play button" to run the manual job
- Insert any value to the variable name
- Press tab
- Notice the red cross appears and does NOT make the rightmost input smaller
- To make sure, compare with the new input that appeared below. They should be the same size!
🎉
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #377272 (closed)
Edited by Frédéric Caplette