Skip to content

Migrate RefSelector to GlCollapsibleListbox

Artur Fedorov requested to merge 386873-migrate-ref_selector-to-listbox into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR resolves #386873 (closed)

Main purpose of this MR is to migrate ref_selector to GlCollapsibleListbox

As first step it changes internally and all props stays untouched because this component is used on many occasions.

Next iteration will be removing unused props:

  • refType

Main UX change is how errors are rendered, new GlCollapsibleListbox doesn't render group section at all if there no items. That's why I moved this section to footer

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

  1. app/assets/javascripts/pages/projects/pipeline_schedules/shared/init_form.js
  2. app/assets/javascripts/branches/init_new_branch_ref_selector.js
  3. app/assets/javascripts/ci/pipeline_schedules/components/pipeline_schedules_form.vue
  4. ee/app/assets/javascripts/on_demand_scans_form/components/on_demand_scans_form.vue
  5. app/assets/javascripts/pipeline_wizard/components/commit.vue
  6. app/assets/javascripts/projects/commits/index.js
  7. app/assets/javascripts/projects/settings/components/default_branch_selector.vue
  8. app/assets/javascripts/releases/components/tag_field_new.vue
  9. app/assets/javascripts/repository/index.js
  10. app/assets/javascripts/search/under_topbar/index.js
  11. app/assets/javascripts/tags/init_new_tag_ref_selector.js
Component AFTER
pipeline_schedules/shared/init_form.js Screenshot_2023-01-09_at_17.25.26
branches/init_new_branch_ref_selector.js Screenshot_2023-01-09_at_17.23.13
on_demand_scans_form/components/on_demand_scans_form.vue Screenshot_2023-01-09_at_17.24.22
pipeline_wizard/components/commit.vue Screenshot_2023-01-09_at_17.26.59
settings/components/default_branch_selector.vue Screenshot_2023-01-09_at_17.28.23
releases/components/tag_field_new.vue Screenshot_2023-01-09_at_17.30.28
repository/index.js Screenshot_2023-01-09_at_17.31.47
tags/init_new_tag_ref_selector.js Screenshot_2023-01-09_at_17.34.11
New error state
Screenshot_2023-01-17_at_16.18.58

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #386873 (closed)

Edited by Artur Fedorov

Merge request reports