GraphQL: Deprecate `Projects::ServiceType` interface

changed milestone to %15.8

added Category:API Category:Integrations GraphQL Seeking community contributions Stretch [deprecated] Accepting merge requests backend devopsmanage groupintegrations [DEPRECATED] maintenancerefactor missed-deliverable missed:14.1 missed:15.7 sectiondev typemaintenance labels

assigned to @bmarjanovic

added 3 commits

a0c01552...59ab0775 - 2 commits from branch master
a6b0c37b - Deprecate `Projects::ServiceType` interface

Compare with previous version

added documentation label

	1 Message
	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

Documentation review

The following files require a review from a technical writer:

doc/api/graphql/reference/index.md (Link to current live version)

The review does not need to block merging this merge request. See the:

Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
The Technical Writer assigned for that stage and group.
Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Alex Buijs (`@alexbuijs`) (UTC+1, same timezone as `@bmarjanovic`)	Aleksei Lipniagov (`@alipniagov`) (UTC+1, same timezone as `@bmarjanovic`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

removed Seeking community contributions label

added 1 commit

2f4fcaef - Fix specs

Compare with previous version

resolved all threads

added frontend label

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 6562dc13 and e64133d0

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.56 MB	3.56 MB	-	-0.0 %
mainChunk	1.95 MB	1.95 MB	-	0.0 %

Note: We do not have exact data for 6562dc13. So we have used data from: 2dd20331.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for e64133d0

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Manage           | 33     | 0      | 3       | 0     | 36    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Verify           | 12     | 0      | 0       | 0     | 12    | ✅     |
| Govern           | 28     | 0      | 5       | 0     | 33    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 163    | 0      | 12      | 0     | 175   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

49f9f749 - Deprecate `Projects::ServiceType` interface

Compare with previous version

added pipeline:skip-undercoverage label

changed the description

Hey could you please give a review here?

requested review from @pskorupa, @farias-gl, and @ashrafkhamis

marked this merge request as ready

added Technical Writing docsimprovement labels

removed review request for @ashrafkhamis

requested review from @ashrafkhamis

approved this merge request

@ashrafkhamis, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

removed review request for @ashrafkhamis

added 347 commits

49f9f749...f24a89a8 - 346 commits from branch master
64236f50 - Deprecate `Projects::ServiceType` interface

Compare with previous version

resolved all threads

added 269 commits

64236f50...0e0b218e - 268 commits from branch master
6a9a2cd4 - Deprecate `Projects::ServiceType` interface

Compare with previous version

@bmarjanovic I thought I had replied yesterday, my apologies. I didn't see much of anything frontend to review in terms of code style/patterns/syntax. I'm assuming the roulette wheel saw the .json file and required a frontend reviewer

suggestion

Assign to a maintainer who is familiar with the Project Services API because they would be best able to tell you if the deprecation would break any frontend endpoints that may be relying on it.