Skip to content

Remove double-up of clear icons from search inputs

Hinam Mehra requested to merge fix-clear-icon-in-search-inputs into master

What does this MR do and why?

  • Browsers add an additional clear icon to type=search fields. This was overlapping with the clear icon we add programatically in input fields.
  • I believe this started happening because the code to overwrite this existed in search.scss, but the file was recently removed from global scope and added as a page-specific style (!105818 (diffs)).
  • To make it more uniform with other browser overwrites of inputs, I have just added this to forms.scss

Screenshots or screen recordings

Before After

How to set up and validate locally

  1. Sign in as a user and navigate to a merge request created by you
  2. Then try to add reviewers to the merge request.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hinam Mehra

Merge request reports