Adjust CLI notification messages
What does this MR do and why?
This MR closes https://gitlab.com/gitlab-org/gitlab/-/issues/360326
- Adjust the namespace CLI notification messages for warnings to show only on the 0.95 alert level
- The error messages in the
pos_recieve
were not reached since it was returning in the pre-hook - The only place we can adjust the namespace
error
messages areNamespaceStorageSizeErrorMessage
-
NamespaceStorageSizeErrorMessage
used to havestorage_limit_reached_error_msg
which shows no usage data - Adjust the CLI notifications for errors, to include the usage data, and remove
storage_limit_reached_error_msg
- Overall we should not have any class methods here since we need the usage data always for messages
- Change the
commit_error
to be independent, after it was using thepush_error
- Add the new usage data details to the
push_error
which is first touched in theCLI
- Add a new class for CLI notifications,
'Namespaces::Storage::CliNotification'
- Adjust docs to include notifications delivery notes in
doc/user/usage_quotas.md
- This MR is not changing anything for banners notifications, banner changes are in !106697 (merged)
How to set up and validate locally
Please follow the steps in !111066 (merged) once it's merged.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Mohamed Hamda