Remove two_line_mention_enabled feature flag
What does this MR do and why?
Based on feedback (#385261 (comment 1226150785)) a new To-Do design for mentions was implemented behind a feature flag to first test with realistic data. This MR now removes that feature flag and makes the new design available for everyone.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mvanremmerden
mentioned in issue #385261 (closed)
- A deleted user
added backend label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Bojan Marjanović (
@bmarjanovic
) (UTC+1)Charlie Ablett (
@cablett
) (UTC+13)frontend Rahul Chanila (
@rchanila
) (UTC+11)Miguel Rincon (
@mrincon
) (UTC+1)test for spec/features/*
Bojan Marjanović (
@bmarjanovic
) (UTC+1)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 23a2f40dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 372 | 0 | 0 | 0 | 372 | ✅ | | Verify | 298 | 0 | 20 | 6 | 318 | ❗ | | Manage | 390 | 0 | 18 | 5 | 408 | ❗ | | Create | 971 | 0 | 32 | 0 | 1003 | ✅ | | Fulfillment | 12 | 0 | 84 | 0 | 96 | ✅ | | Package | 125 | 0 | 22 | 6 | 147 | ❗ | | Release | 36 | 0 | 0 | 0 | 36 | ✅ | | Configure | 0 | 0 | 18 | 0 | 18 | ➖ | | Govern | 256 | 0 | 6 | 0 | 262 | ✅ | | Secure | 42 | 0 | 6 | 12 | 48 | ❗ | | Monitor | 24 | 0 | 0 | 0 | 24 | ✅ | | Analytics | 12 | 0 | 0 | 0 | 12 | ✅ | | Framework sanity | 0 | 0 | 8 | 0 | 8 | ➖ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2540 | 0 | 220 | 29 | 2760 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Aleksei Lipniagov
@alexbuijs @mgandres Would you two mind reviewing this MR?
requested review from @alexbuijs and @mgandres
@mgandres
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @jerasmus
removed review request for @mgandres
removed review request for @jerasmus
requested review from @alipniagov and removed review request for @alexbuijs
enabled an automatic merge when the pipeline for bd84f1f0 succeeds
mentioned in commit 15185154
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1829 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in commit dd5d8109
mentioned in merge request !149193 (merged)
mentioned in merge request !148829 (merged)