Skip to content

Store approving user for access requests

Niklas van Schrick requested to merge gitlab-community/gitlab:access-request-store-user into master

What does this MR do and why?

If a user joins a project or group via an access request, the approver is not saved and there is no way to find out who added that member.

This MR stores the approving user into the created_by column like it is done if a user is added directly.

Screenshots or screen recordings

Old behaviour New behaviour
image image

How to set up and validate locally

With code from master

  1. Request access to a project as non-member
  2. Approve the access request as project-maintainer
  3. Observe that the membership does not show who added the member

With code from the MR

  1. Request access to a project as non-member
  2. Approve the access request as project-maintainer
  3. Observe that the membership now does show who added the member

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports