Fix flaky test in Terraform feature spec

What does this MR do and why?

Issue: #333640 (closed)

The 'when clicking on the delete button' context of the spec/features/projects/terraform_spec.rb was failing.

The change here ensures that the object being tested is created before the Terraform page is loaded. There are also additional changes in expected behavior because this deletion workflow has changed since this test was quarantined.

Screenshots or screen recordings

For reference on what the spec is testing, this is what the Terraform page looks like when a state is deleted:

How to set up and validate locally

Run the spec/features/projects/terraform_spec.rb spec

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.