Fix Write and Preview tabs in the summary review comment in dark mode
requested to merge 370482-in-dark-mode-the-write-and-preview-tabs-are-no-visible-in-the-summary-review-comment into master
What does this MR do and why?
Fix hidden text in summary review comment in dark mode.
Page bundles don't get SCSS variables from dark mode (they are compiled separately), so $gray-900
is the light mode equivalent (#333 (closed) ish). Change to using CSS custom property, and use the --gl-text-color
. This is still the same color, but is correctly switched in dark mode.
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable dark mode
- Start a review on an MR
- Click "Submit review"
- Check tabs above textbox
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #370482 (closed)
Edited by Simon Knox