Skip to content

Fix Write and Preview tabs in the summary review comment in dark mode

What does this MR do and why?

Fix hidden text in summary review comment in dark mode.

Page bundles don't get SCSS variables from dark mode (they are compiled separately), so $gray-900 is the light mode equivalent (#333 (closed) ish). Change to using CSS custom property, and use the --gl-text-color. This is still the same color, but is correctly switched in dark mode.

Screenshots or screen recordings

before after
image Screenshot_2023-01-05_at_1.40.11_pm

How to set up and validate locally

  1. Enable dark mode
  2. Start a review on an MR
  3. Click "Submit review"
  4. Check tabs above textbox

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #370482 (closed)

Edited by Simon Knox

Merge request reports