Remove unused userSelect from app/assets/javascripts/pages/projects/merge_requests/index/index.js
What does this MR do and why?
This MR removes unused userSelect
from app/assets/javascripts/pages/projects/merge_requests/index/index.js.
Screenshots or screen recordings
No visual changes.
How to set up and validate locally
- Go to the merge requests page.
- Click Edit and select some MRs.
- Verify the assignee select works as expected.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Review progress:
Related to #369997 (closed)
Merge request reports
Activity
assigned to @anna_vovchenko
added sectionops label and removed sectiondev label
added pipeline:run-all-rspec label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Alper Akgun (
@a_akgun
) (UTC+3, 1 hour ahead of@anna_vovchenko
)Frédéric Caplette (
@f_caplette
) (UTC-5, 7 hours behind@anna_vovchenko
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.8
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ee759af3 and 2d797adb
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.56 MB 3.56 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 2d797adbexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 33 | 0 | 3 | 0 | 36 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 27 | 0 | 5 | 0 | 32 | ✅ | | Verify | 12 | 0 | 0 | 0 | 12 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 0 | 174 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2d797adbexpand test summary
+----------------------------------------------------------------+ | suites summary | +-----------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-----------+--------+--------+---------+-------+-------+--------+ | Configure | 0 | 0 | 12 | 0 | 12 | ➖ | +-----------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 12 | 0 | 12 | ➖ | +-----------+--------+--------+---------+-------+-------+--------+
mentioned in issue anna_vovchenko/performance-and-growth#3
changed milestone to %15.9
added missed:15.8 label
added 4520 commits
-
1658242a...0809d6f2 - 4519 commits from branch
master
- 2d797adb - Remove unused import of UsersSelect
-
1658242a...0809d6f2 - 4519 commits from branch
removed pipeline:run-all-rspec label
- Resolved by Frédéric Caplette
@elwyn-gitlab, after your MR Replace user_select dropdown in Issues list bul... (!108509 - merged) is done, the assignee widget on the merge requests bulk edit works without the jQuery userSelect. Would you mind doing the frontend review?
requested review from @elwyn-gitlab
@elwyn-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @f_caplette and removed review request for @elwyn-gitlab
marked the checklist item frontend developer review as completed
enabled an automatic merge when the pipeline for 5e126acd succeeds
mentioned in commit 38626854
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
marked the checklist item frontend maintainer review as completed
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupenvironments label and removed groupconfigure [DEPRECATED] label