Skip to content

Draft: Reproduce variables evaluation error

Fabio Pitino requested to merge fix-seed-variables-evaluation into master

What does this MR do and why?

Related to #350057

This MR is purely for investigating what happened with #385970 (comment 1213109228) which caused the FF code removal from being reverted and FF disabled due to bugs reported by customers.

In the issue reported by customers we can see that when environment uses a variable that can be changed by rules it wasn't being applied correctly.

It turns out that the cause of this bug was the memoization we do with simple_variables and expanded_environment_name used when we call build.scoped_variables. In scoped_variables the default environment: argument is expanded_environment_name which is memoized. Since in the new approach added by the FF we reuse the same processable object, the memoization was preventing changes from rules from being reflected.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports