Avoid false positive for '1st'
What does this MR do and why?
The vale rule that asks for a space between 1 and s (to mean "1 second") is showing a false positive in this file. The text reads 1st April.
This MR updates the regex to make an exception for 1s if there is a "t" after the "s".
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- Run Vale against a file that previously had false positives:
vale --config .vale.ini doc/ci/pipelines/cicd_minutes.md
- You should not get a
gitlab.Units
warning. - Edit cicd_minutes.md and add something that should warn (e.g,
1s
) - Run the check again:
vale --config .vale.ini doc/ci/pipelines/cicd_minutes.md
- This time, you should get a
gitlab.Units
warning.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Sarah German