Skip to content

Drop justify-content-center class in favor of align prop

Paul Gascou-Vaillancourt requested to merge table-pagination-center-align into master

What does this MR do and why?

With some recent markup changes in GlPagination, the table-pagination component's alignment doesn't seem to apply properly anymore. The reason likely is that alignment classes need to be set on the <ul> tag, which is now wrapped within a <nav> tag. Instead of manually adding the justify-content-center class, we can leverage the align prop which will take care of adding the class to the correct element.

Screenshots or screen recordings

Before After
Screenshot_2023-01-03_at_1.52.44_PM Screenshot_2023-01-03_at_1.52.21_PM

How to set up and validate locally

  1. Navigate to a project's pipelines page (/:namespace/:project/-/pipelines)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports