Skip to content

Add data to shouldCollapse method of MR Widget Extension

Jannik Lehmann requested to merge jnnkl-mr-widget-extension-should-collapse into master

What does this MR do and why?

This MR adds collapsed Data as a param to the should Collapse method of the MR Widget Extension to enable setting this option dynamically.

This option was so far used in a static way. For certain use-cases (eg. CodeQuality MR Widget) we need this option to be dynamic. The CodeQuality MR Widget will be expandable when there are resolved or new errors, but it won't be expandable if there are no changes.

Link to Docs: https://docs.gitlab.com/ee/development/fe_guide/merge_request_widget_extensions.html

Screenshots or screen recordings

no visual changes.

How to set up and validate locally

Nothing to execute yet, just an api change.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports