Skip to content

Remove skip_ensure_merge_request_diff FF

Sincheol (David) Kim requested to merge 376759-feature-flag-rollout-of-async_merge_request_diff_creation into master

What does this MR do and why?

We have enabled skip_ensure_merge_request_diff feature flag about a month ago and I believe we can now remove the FF as it seems stable.

I was thinking about removing skip_ensure_merge_request_diff option and after_create :ensure_merge_request_diff, but that would require quite a bit of effort to fix existing specs so I decided against it for now. Also, it gives us the option if we prefer synchronous creation in certain situation so I think it makes sense to leave them as is.

Related to #376759 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #376759 (closed)

Edited by Sincheol (David) Kim

Merge request reports