Skip to content

Delete old Golden Master markdown testing approach

Chad Woolley requested to merge caw-delete-golden-master-markdown-specs into master

What does this MR do and why?

Related: Tracking Issue: Implement GLFM scripts per the ... (#361241)

Closes: Tracking Issue: Migrate existing specs Golden M... (#361242 - closed)

This is the final MR to complete Tracking Issue: Migrate existing specs Golden M... (#361242 - closed), by removing all references to the old golden master based approach to markdown conformance testing, which has been replaced with https://docs.gitlab.com/ee/development/gitlab_flavored_markdown/specification_guide/#markdown-snapshot-testing

The only remaining references to golden_master in the codebase are in the files under glfm_specification/..., which contain references to ...migrated_golden_master_examples..., for the examples which have been migrated from the old to the new approach.

References

See the GLFM Specification Guide development documentation for much more context on all of this work: https://docs.gitlab.com/ee/development/gitlab_flavored_markdown/specification_guide

How to set up and validate locally

Should be good to go as long as nothing breaks in the pipeline. pipeline:run-all-rspec pipeline:run-all-jest have been applied to ensure full regression coverage.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Chad Woolley

Merge request reports