Skip to content

Fixes statements about "all branches"

Amy Qualls requested to merge 333836-aqualls-all-branches into master

What does this MR do?

Revises these two sections of the approval-rules page:

The descriptions of branches were a bit mangled:

  • The subheading for adding an approval rule didn't say anything about selecting branches
  • The subheading for adding an approval rule to protected branches included a full description of selecting which branches to protect, rather than just the subset of protected branches.

This merge request adds the branch-related info to the general add-a-rule section, and simplifies the description of what branches to pick when setting up approvals for protected branches. (It also deletes an outdated version history line.)

Related issues

Closes Review mentions of "any branch" (#333836 - closed)

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.
Edited by Amy Qualls

Merge request reports