Skip to content

Cleanup global policy specs

Pedro Pombeiro requested to merge pedropombeiro/377963/cleanup-global-policy-specs into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR brings 2 minor cleanups to the GlobalPolicy class:

  • Makes the specs more readable by replacing .not_to be_allowed with .to be_disallowed;
  • Reduces the number of factory calls to create admin users (10 calls reduced to 3 calls).

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports