Skip to content

Fix the feature flag actor for Pages menu position experiment

Janis Altherr requested to merge fix-pages-menu-experiment-actor into master

What does this MR do and why?

This MR fixes an issue where the wrong FF actor was selected for the experiment feature flag.

This is the Experiment description:

#373547 (closed)

The FF actor should be user, not project. I have no idea how I missed this.

Note:

I am aware that the tests do not test the updated path. Since this is a short-lived experiment (A/B test) this has been considered acceptable in the original MR. Should the new position be accepted as a result of the experiment, the tests will be updated in the FF removal MR.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable the Feature flag: echo "Feature.enable(:show_pages_in_deployments_menu, User.find(<user_id>))" | bin/rails c
  2. Navigate to a Project
  3. Observe how the Menu entry for Pages is now located under "Deployments" and no longer under "Settings"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Janis Altherr

Merge request reports