Skip to content

Revert !107233

Miguel Rincon requested to merge revert-14c96925 into master

What does this MR do and why?

Reverts !107233 (merged)


I want to revert !107233 (merged) due to #386591 (closed).

Initially I wanted improve the way we process this HTML, that comes from the string directly, but it looks like this apparently simple line does a bit heavy lifting for us:

$(this.note.note_html).unwrap().html();

and considers some edge cases that I didn't consider during review:

This may lead to some missing content in some cases, some errors in others, so I have opted to revert while we improve our coverage of spec/frontend/vue_shared/components/notes/system_note_spec.js.

Screenshots or screen recordings

NA

How to set up and validate locally

NA

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports