Fix(Subscr.): success notification + loading icon
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR removes the loading (info) banner added here and replaces it with a "sticky" banner with a message that the subscription details will complete momentarily. It also adds a loading icon in place of the "sync" icon, when the request is ongoing.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before (notification disappears) | After (notification sticks) |
|---|---|
 |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Local test
- Visit
http://127.0.0.1:3000/admin/subscription - Apply this patch and comment in the online cloud license: test-different-licenses.patch
- Click the sync icon and you should see the loading state followed by the success state.
Actual test
- Visit
http://127.0.0.1:3000/admin/subscription - Make sure to have CustomersDot set up with Zuora to create an online cloud license. You can follow the instructions here (a bit out-dated, but still works): https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/staging/doc/resource_videos.md
- Find the subscription activation code in the email that gets generated from the purchase or find it in CustomersDot http://localhost:5000/ and add it to your instance.
- Click the sync icon and you should see the loading state followed by the success state.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to customers-gitlab-com#5318 (closed)
Edited by Michael Lunøe