Migrate GlDropdown toolbar_text_style_dropdown.vue

added OKR-FY24Q2 component:dropdown devopsmanage frontend groupfoundations maintenancerefactor pajamasintegrate sectiondev severity4 typemaintenance workflowready for development + 1 deleted label

assigned to @psjakubowska

added 1 commit

e8acfab5 - Migrate ToolbarTextStyle to GlListbox

Compare with previous version

	1 Warning
	This merge request contains lines with QA selectors. Please ensure `e2e:package-and-test` job is run.

QA Selectors

The following changed lines in this MR contain QA selectors:

file app/assets/javascripts/content_editor/components/toolbar_text_style_dropdown.vue:
- ```
 data-qa-selector="text_style_dropdown"
```

   data-qa-selector="text_style_menu_item"

- ```
 data-qa-selector="text_style_dropdown"
```

Please ensure e2e:package-and-test job is run and the tests are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Doug Stull (`@dstull`) (UTC-5)	Natalia Tepluhina (`@ntepluhina`) (UTC+1)
QA	Careem Ahamed (`@cahamed`) (UTC+8)	Maintainer review is optional for QA

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 5bcacfe4 and 7d18ced6

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.52 MB	3.52 MB	-	0.0 %
mainChunk	1.96 MB	1.96 MB	-	0.0 %

Note: We do not have exact data for 5bcacfe4. So we have used data from: b6cb8b8d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 7d18ced6

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Manage           | 34     | 0      | 3       | 1     | 37    | ❗     |
| Govern           | 24     | 0      | 5       | 0     | 29    | ✅     |
| Verify           | 12     | 0      | 1       | 0     | 13    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 156    | 0      | 13      | 1     | 169   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 7d18ced6

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Manage           | 375    | 4      | 18      | 29    | 397   | ❌     |
| Verify           | 244    | 0      | 17      | 5     | 261   | ❗     |
| Create           | 756    | 73     | 27      | 10    | 856   | ❌     |
| Govern           | 215    | 0      | 5       | 0     | 220   | ✅     |
| Plan             | 312    | 0      | 0       | 0     | 312   | ✅     |
| Release          | 30     | 0      | 0       | 0     | 30    | ✅     |
| ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
| Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
| Package          | 144    | 0      | 37      | 12    | 181   | ❗     |
| Monitor          | 20     | 0      | 0       | 0     | 20    | ✅     |
| Analytics        | 11     | 0      | 0       | 0     | 11    | ✅     |
| Fulfillment      | 12     | 0      | 70      | 0     | 82    | ✅     |
| Secure           | 35     | 0      | 5       | 0     | 40    | ✅     |
| Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Data Stores      | 11     | 0      | 3       | 0     | 14    | ✅     |
| Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 2187   | 77     | 210     | 56    | 2474  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

added 917 commits

db144230...1063fb16 - 915 commits from branch master
e1529854 - Migrate ToolbarTextStyle to GlListbox
976c085a - Fix tests

Compare with previous version

changed the description

added 1 commit

9f87bed4 - Fix tooltip for text style dropdown

Compare with previous version

changed the description

changed title from Draft: Resolve "Migrate GlDropdown in app/assets/javascripts/content_editor/components/toolbar_text_style_dropdown.vue to GlCollapsibleListbox" to Draft: Resolve "Migrate GlDropdown toolbar_text_style_dropdown.vue to GlCollapsibleListbox"

changed milestone to %15.8

added 1 commit

9dd8af51 - Migrate ToolbarTextStyle to GlListbox

Compare with previous version

added workflowin dev label and removed workflowready for development label

changed title from Draft: Resolve "Migrate GlDropdown toolbar_text_style_dropdown.vue to GlCollapsibleListbox" to Draft: Migrate GlDropdown toolbar_text_style_dropdown.vue

added 1 commit

65513220 - Fix test issues

Compare with previous version

added QA label

changed the description

added 1 commit

5e5dc80b - Fix test issues

Compare with previous version

added 1 commit

3e8c35c0 - Fix test issues

Compare with previous version

added 1 commit

83757d85 - Adjust tests to a migrated component

Compare with previous version

marked this merge request as ready

added 444 commits

83757d85...bbf7bab4 - 442 commits from branch master
7c325c4b - Migrate ToolbarTextStyle to GlListbox
98b8f339 - Adjust tests to a migrated component

Compare with previous version

requested review from @sdejonge and @cahamed

Hi @sdejonge , @cahamed! Could you review this dropdown migration? Thank you!

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

removed review request for @sdejonge

approved this merge request

@cahamed, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

added 1 commit

7d18ced6 - Migrate ToolbarTextStyle to GlListbox

Compare with previous version

requested review from @sdejonge

approved this merge request

requested review from @ntepluhina and removed review request for @sdejonge

@psjakubowska nice work! I have a few comments but since they all are non-blocking, I'll proceed to merge

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 0a018316 succeeds

resolved all threads

merged

canceled the automatic merge

@ntepluhina, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago, and finished more than 2 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to merge when pipeline succeeds.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.