Skip to content

Add standalone finding modal component

Daniel Tian requested to merge 382913-add-standalone-finding-modal into master

What does this MR do and why?

Currently, ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue is used to show the info modal for a finding on the pipeline security tab and the MR security widget. This component expects that the parent component uses Vuex, but we're moving away from Vuex. This MR adds a finding_modal.vue component that wraps modal.vue and moves the Vuex code into this component, in order to break the Vuex dependency.

Note that for this MR finding_modal.vue is read only, and the actions are all noop functions that will be added in later MRs.

2022-12-20_01-09-57

How to set up and validate locally

  1. Enable the standalone_finding_modal feature flag.
  2. Run a pipeline that has security vulnerabilities, if you haven't already.
  3. Go to the pipeline and click on the security tab.
  4. Click on any finding in the list to bring up the modal.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382913 (closed)

Merge request reports