Skip to content

Geo: Remove Replication sidebar nav link

Michael Kozono requested to merge mk/avoid-route-that-does-not-work-on-primary into master

What does this MR do and why?

This MR only reduces the impact of the current problem until the real resolution occurs during &3588 (closed).

Currently, the UI invites users to discover a known limitation, by clicking on a sidebar nav link which may or may not work. Instead, users should use the Replication Details links for each site, in Admin > Geo > Sites.

This MR helps avoid sending users to the /admin/geo/replication/projects route. That route is broken when accessed on the primary. And it does not work at all when Admin Mode is enabled. The route is still accessible when needed, by clicking on Projects on the Geo Replication view. But it requires more intentionality to visit.

Alternatively, we could set the Replication nav link to point to an SSF data type instead of Projects, such as LFS objects, e.g. /admin/geo/sites/2/replication/lfs_objects. That way, the Replication nav link always works. However if there is more than one secondary site, then we would then be forced to arbitrarily choose one, which is poor UX considering that the chosen site may not be desired site, and there is no way to switch to the desired site with the current UI without going back to Admin > Geo > Sites anyway.

Also with this MR, the UI hierarchy will be closer to reality, which is: Admin > Geo > Sites > Replication Details.

Therefore, while it is not ideal, it is better to remove the Replication sidebar nav link, and make people use the Replication Details links provided on Admin > Geo > Sites.

Related to #369879 (closed) and #339453 (closed)

Screenshots or screen recordings

Before

Screenshot_2022-12-19_at_3.51.52_PM

Screenshot_2022-12-19_at_3.52.11_PM

After

Screenshot_2022-12-19_at_12.32.55_PM

Screenshot_2022-12-19_at_12.32.50_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit Admin > Geo, and notice no Replication sidebar nav link
  2. Under a secondary site's Replication Details, click on an SSF data type, and notice no Replication sidebar nav link
  3. While browsing the secondary site, under a secondary site's Replication Details, click on Repositories, and notice no Replication sidebar nav link.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Michael Kozono

Merge request reports