Move OnCall Schedules timezone to the shared Timezone Dropdown
What does this MR do and why?
- Migrates custom GlDropdown in creating oncall schedule modal, to a shared TimezoneDropdown. There is a slight difference in formatting (
[]
instead of()
for UTM) - I decided to keep it as is for consistency across application (see CI/CD > Schedules > New Schedule for reference). - Adds a dropdownClass property to customise shared dropdown. In case of oncall form, extra margin did not allow to display validation message directly under the box. Hence the addition and reset to 0px.
- Adds a unit test to TimezoneDropdown for marking selected timezone.
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Prerequisite:
- This is a premium feature
- You must have at least the Maintainer role.
To open create an on-call schedule modal:
- On the top bar, select Main menu > Projects and find your project.
- On the left sidebar, select Monitor > On-call Schedules.
- Select Add a schedule.
- Enter the schedule’s name and description and select a time zone.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #378631 (closed)
Merge request reports
Activity
added OKR-FY24Q2 UX component:dropdown dropdownlistbox frontend maintenancerefactor pajamasintegrate severity4 typemaintenance + 1 deleted label
assigned to @psjakubowska
Setting label grouprespond based on
@psjakubowska
's group.added grouprespond label
Setting label(s) devopsmonitor sectionops based on grouprespond.
added devopsmonitor sectionops labels
added 372 commits
-
36e1648b...ed200b01 - 371 commits from branch
master
- 5cdd23f3 - Use TimezoneDropdown in oncall schedule create
-
36e1648b...ed200b01 - 371 commits from branch
1 Warning This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/timezone_dropdown/timezone_dropdown.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova (
@dzubova
) (UTC+1)Jannik Lehmann (
@jannik_lehmann
) (UTC+1)test for spec/features/*
Alex Buijs (
@alexbuijs
) (UTC+1)Maintainer review is optional for test for spec/features/*
UX Ali Ndlovu (
@andlovu
) (UTC+2)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 739a145d and 385db55f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.52 MB 3.52 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for 739a145d. So we have used data from: 4028cdd6.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- a41d7b9d - Use TimezoneDropdown in oncall schedule create
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 385db55fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 34 | 0 | 3 | 1 | 37 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 24 | 0 | 5 | 0 | 29 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 13 | 1 | 169 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Tristan Read
changed milestone to %15.8
removed review request for @mfangman
@mfangman
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @jrushford and @syarynovskyi
- Resolved by Tristan Read
@jrushford, @syarynovskyi , could you take a look at this dropdown migration?
removed review request for @syarynovskyi
- Resolved by Tristan Read
- Resolved by Tristan Read
- Resolved by Tristan Read
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @tristan.read and removed review request for @jrushford
- Resolved by Tristan Read
added 1819 commits
-
1437c143...6d157cbd - 1818 commits from branch
master
- 43b6a530 - Use TimezoneDropdown in oncall schedule create
-
1437c143...6d157cbd - 1818 commits from branch
added 1 commit
- 569ebaab - Use TimezoneDropdown in oncall schedule create
added 1 commit
- 385db55f - Use TimezoneDropdown in oncall schedule create
Thanks for applying my suggestion @psjakubowska. The changes look good to me, I'll approve and set MWPS
enabled an automatic merge when the pipeline for 5ff5d166 succeeds
mentioned in commit ff3da687
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1829 (merged)
mentioned in issue #378631 (closed)
mentioned in issue gitlab-org/monitor/respond#195 (closed)
added releasedpublished label and removed releasedcandidate label