Skip to content

Draft: [PoC] add project pages unique domain

Kassio Borges requested to merge kassio/poc-pages-unique-domain into master

What does this MR do and why?

Related to: #385621 (closed)

Screen_Recording_2023-01-08_at_17.07.09

FAQ

  • Why do we need pages_unique_domain and pages_unique_domain_enabled?
    • I think it's best to split these two, because the unique domain generated can be used after multiple enables/disables the feature. This way, if the user bookmark the unique url it'll ways work. Also, In the real feature we might want to introduce a unique constraint in the column, and I think keeping this value might be helpful.

Conclusions/Questions

  • The change is actually not too big.
  • The feature flag could be only in the UI/User facing change (easier to clean it later)
  • Would be nice to add a Finder for the /api/internal/pages lookup logic (added a code suggestion for that)
  • Most of the work is in the gitlab project
  • In this PoC I exposed the unique_domain in the internal API with the intent of adding an auto-redirect from default domain to the unique_domain. But didn't PoC that in the gitlab-pages code.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Kassio Borges

Merge request reports