Skip to content

Migrate Markdown buttons to the Source Editor toolbar

What does this MR do and why?

The MR moves the Markdown buttons from the original toolbar to the Source Editor toolbar. The change is protected with a feature flag.

Screenshots or screen recordings

Before After
Markdown file Screenshot_2022-12-13_at_16.46.08 Screenshot_2022-12-15_at_11.45.42
YML Screenshot_2022-12-15_at_11.51.55 Screenshot_2022-12-15_at_11.46.48
Javascript Screenshot_2022-12-13_at_16.47.15 Screenshot_2022-12-15_at_11.47.29

How to set up and validate locally

  1. Enable the feature flag locally in the Rails console (rails c): Feature.enable(:source_editor_toolbar)
  2. In the browser, go to a repository, open a markdown file and click "Edit" (not Web IDE, or GitPod)
  3. Note the updated toolbar.
  4. Play with the buttons to ensure they do what they are supposed to do. If in doubt, try editing (not committing) a markdown file on gitlab.com to see the expected behavior.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #352662 (closed)

Edited by Denys Mishunov

Merge request reports